feat: add ndarray/base/binary-input-casting-dtype
#7904
+1,089
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gururaj1512
added
GSoC
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Currently the examples are failing. But it can be tackled through function safeInputCastingDataType( dtype1, dtype2, dtype3, policy ) {
try {
return inputCastingDataType( dtype1, dtype2, dtype3, policy );
} catch ( error ) {
if ( policy === 'none' && ( dtype1 !== dtype2 || dtype2 !== dtype3 ) ) {
return 'incompatible';
}
return error;
}
}
// Resolve casting data types:
logEachMap( 'dtypes: (%10s, %10s, %10s). policy: %20s. result: %10s.', args[ 0 ], args[ 1 ], args[ 2 ], args[ 3 ], naryFunction( safeInputCastingDataType, 4 ) );Is above method correct? Or do we have similar packages/method to perform it? |
kgryte
reviewed
Aug 28, 2025
| var inputCastingDataType = require( './../lib' ); | ||
|
|
||
| // Get the list of real-valued data types: | ||
| var dt = dtypes( 'real' ); |
There was a problem hiding this comment.
@gururaj1512 Rather than dynamically generating the list as you do here, how about just hardcoding idt1, idt2, and odt with data types which are known to succeed according to the listed policies? E.g.,
var idt1 = [
'float32',
'float64'
];
var idt2 = [
'int8',
'uint8'
];
var odt = [
'float32',
'float64',
'complex64',
'complex128'
];In short, can you engineer some combinations which work, rather than using the most generalized approach?
kgryte
added
Needs Changes
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves None
Description
This pull request:
ndarray/base/binary-input-casting-dtypeRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers